PhilSchlo/uncloud
1
0 Fork 0
mirror of https://github.com/psviderski/uncloud.git synced 2026-10-07 13:49:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(compose): remove unnecessary warning validating deploy.mode that is error

Browse Source
This commit is contained in:
Pasha Sviderski committed 2026-09-04 11:00:05 +10:00
1 parent 8aedc2bf19
commit 5e01db5e20
2 files changed
+3 -18
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

pkg/client/compose/service.go
+2 -5
View File
@@ -502,7 +502,8 @@ func validateServicesFeatures(project *types.Project) []error {
errs = append(errs, err(service.Name, "container_name"))
}
if service.Deploy != nil {
if len(service.Deploy.Placement.Constraints) > 0 || len(service.Deploy.Placement.Preferences) > 0 {
if len(service.Deploy.Placement.Constraints) > 0 || len(service.Deploy.Placement.Preferences) > 0 ||
service.Deploy.Placement.MaxReplicas > 0 {
errs = append(errs, fmt.Errorf(
"service '%s': deploy placement is not supported, "+
"use x-machines instead: %s", service.Name,
@@ -513,10 +514,6 @@ func validateServicesFeatures(project *types.Project) []error {
errs = append(errs, fmt.Errorf(
"service '%s': deploy restart_policy defaults to 'unless-stopped'", service.Name))
}
if service.Deploy.Mode != "" && service.Deploy.Mode != "global" && service.Deploy.Mode != "replicated" {
errs = append(errs, fmt.Errorf(
"service '%s': deploy mode must either be 'global' or 'replicated'", service.Name))
}
if service.Deploy.RollbackConfig != nil {
errs = append(errs, err(service.Name, "deploy rollback_config"))
}